Change in ovirt-engine[master]: core: Streamline RemoveExternalEvent canDoAction()
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
......................................................................
core: Streamline RemoveExternalEvent canDoAction()
Streamlined and cleaned up RemoveExternalEventCommand's canDoAction()
method by using the early return pattern and overriding
setActionMessageParameters().
A nice side effect of this cleanup was do solve the possible
NullPointerExcetion FindBugs was complaining about, as the function
would not terminate if the event was null.
Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java
1 file changed, 12 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>