Change in ovirt-engine[master]: core: organize RemoveDiskCommand#canRemoveTemplateDisk
Omer Frenkel has submitted this change and it was merged.
Change subject: core: organize RemoveDiskCommand#canRemoveTemplateDisk
......................................................................
core: organize RemoveDiskCommand#canRemoveTemplateDisk
1. Return false as soon as we detect condition that is not met, instead
of using the 'retValue' variable
2. Extract some code to seperate method in order to make this method
more concise and readable
Change-Id: I7ddc1e6abd85c61ac1486cdd60744124ebfb27b9
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 36 insertions(+), 27 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ddc1e6abd85c61ac1486cdd60744124ebfb27b9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server