Change in ovirt-engine[master]: engine: fix graphics devices handling when creating pool
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: fix graphics devices handling when creating pool
......................................................................
engine: fix graphics devices handling when creating pool
This patch fixes the problem when creating vm pool via UI. Previously, graphics
types of created pool weren't reset in the ui code which caused possible
inheriting of graphics device from a template.
Also, the way of storing graphics devices in AddVmPoolWithVmsParams
was wrong (it wasn't possible to tell the command that particular
graphics device was "reset" in params). This patch changes it so that
this class behaves in the same way as Vm/Template management classes.
Change-Id: I95a6208490709d263ab1bd6e4d5eb9cc6ecb769f
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177231
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
4 files changed, 10 insertions(+), 13 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/36618
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95a6208490709d263ab1bd6e4d5eb9cc6ecb769f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server