Change in ovirt-engine[master]: core: Slight improvements to LexoNumericComparator
Moti Asayag has submitted this change and it was merged.
Change subject: core: Slight improvements to LexoNumericComparator
......................................................................
core: Slight improvements to LexoNumericComparator
Added ability to choose case-sensitiveness of comparison, while the
default behaviour is case-insensitive, and added a couple of
tests. Also ceased the opportunity to change the comparison's return
value to always be -1, 0 or 1 (it used to be possible to return other
numbers corresponding to String differences, which could have been
confusing).
Change-Id: If85552b7d07903321d08d55a7d6675c79692f385
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java
M
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java
2 files changed, 62 insertions(+), 42 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If85552b7d07903321d08d55a7d6675c79692f385
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server