Change in ovirt-engine[master]: userportal: prevent an error dialog in login page
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: prevent an error dialog in login page
......................................................................
userportal: prevent an error dialog in login page
Frontend -> handleActionResult:
* Removed the redundant call to
getEventsHandler().runActionFailed(failed) which invokes an error
dialog without verifying 'isRaiseErrorModalPanel' flag first.
* Removed the method as well since it's not used anymore.
* Now, the error dialog will be invoked only after flag verification
by raising frontendFailureEvent.
* This issue of duplicate dialog invocation was hidden by now
in UserPortal's login page by simply ignoring any error
dialog (removed in Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f).
Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432
Bug-Url: https://bugzilla.redhat.com/957793
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
3 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib240214df319a0122ebcac82bf2b96d608997432
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>