Change in ovirt-engine[master]: core: avoid having LOCKED domain on a failed reconstruct.
Allon Mureinik has submitted this change and it was merged.
Change subject: core: avoid having LOCKED domain on a failed reconstruct.
......................................................................
core: avoid having LOCKED domain on a failed reconstruct.
When the reconstruct command is being executed during its CDA phase
the pool's domains statuses are loaded and are checked for being different
then LOCKED.
getStorageDomain() is being called prior to the CDA check from
getJobMessageProperties(), which means that possibly the loaded domain
would be in status LOCKED.
In case of using compensation through reconstruct, the domain status
might be reverted to LOCKED instead of to it's actual status.
This patch only verifies that the loaded domain within
getStorageDomain() isn't LOCKED, a further behaviour change might be
needed generally.
Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server