Change in ovirt-engine[master]: engine, webadmin: Allow creation of cluster of required version
Sahina Bose has submitted this change and it was merged.
Change subject: engine, webadmin: Allow creation of cluster of required version
......................................................................
engine, webadmin: Allow creation of cluster of required version
This patch allows creation of required version cluster in gluster-only mode.
The approach taken is :
1. Show all avilable versions instead of only the latest
This is achieved by passing null(ONLY IN GLUSTER_ONLY MODE) as datacenter
id to the query that fetches the versions based on datacenter version.
And the query is intelligent to handle this.
2. By default the Default cluster is of highest supported version and in
gluster-only mode the data center is not editable or even for that matter
visible. This blocks the creation of a cluster with any version lower than
highest supported version.This patch hence relaxes,
ClusterValidator#dataCenterVersionMismatch for gluster-only mode
Change-Id: Idc81ec4e7e0cac9109cb21ab5b4a1bb8c1138ee5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1056936
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ClusterValidatorTest.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
5 files changed, 27 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
anmolbabu: Verified
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc81ec4e7e0cac9109cb21ab5b4a1bb8c1138ee5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org