Change in ovirt-engine[ovirt-engine-3.6.4]: core: CommandBase - avoid setting end status prematurely
Tal Nisan has submitted this change and it was merged.
Change subject: core: CommandBase - avoid setting end status prematurely
......................................................................
core: CommandBase - avoid setting end status prematurely
In change I49b7f506dc1142c3a559d0e6f64813e2ade02254 the code checking whether
the command should status should be updated after execution was updated.
As some of the commands are adding the tasks to the internal task id list
instead of using the getTaskIdList() method it'll cause those commands to be marked
as ended although the tasks are still running.
This patch adds a check to the internal list as well to avoid that issue.
Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310390
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54433
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2251dd808734f297c5e3907b9f106d6cf87fbd18
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.4
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>