Change in ovirt-engine[master]: webadmin: improve error checking on import dialog
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: improve error checking on import dialog
......................................................................
webadmin: improve error checking on import dialog
Consider the following scenario:
1. VM with id=1 and name='A' already exists in the system
2. The user is about to import a VM with id=2 and name='A'
We would expect the UI to tell the user that the VM already exists so
he'll choose a different name. However, the actual result is that the UI
pass the request to the backend, and the backend generates the error.
This patch solves it.
Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmData.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
4 files changed, 65 insertions(+), 24 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/40310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3f7e8d1780dc500f1c400559b6e4a40ebcd32ef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org