Change in ovirt-engine[ovirt-engine-3.3]: core: don't load disks for templates on search
Itamar Heim has submitted this change and it was merged.
Change subject: core: don't load disks for templates on search
......................................................................
core: don't load disks for templates on search
When searching for templates,
the search loads all the disks for each template.
this is not necessary as disks are a different collection that need to
be fetched upon request,
also the disks are not used currently by the search initiators,
and it make the templates search slow for systems with many templates.
this patch removes the disks population on templates search.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070265
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907
Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
4 files changed, 23 insertions(+), 11 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Itamar Heim: Verified
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server