Change in ovirt-engine[master]: core: toward deprecation of the speed of vm interface
From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: toward deprecation of the speed of vm interface
......................................................................
core: toward deprecation of the speed of vm interface
Today, VDSM reports the speed of a VM network interface. It just determines
that according to the model of the interface (e1000/virtio/...) [1]. This
is redundant since the engine already knows the model of the interface,
so it can figure out the speed on its own.
This patch introduces a preparation for deprecating this field. The reason
for doing it now is that the speed is not reported by collectd and we do
not wish to add it to collectd.
[1] https://github.com/oVirt/vdsm/blob/master/lib/vdsm/virt/vmstats.py#L286
Change-Id: Iafb14eb481d099ec89ed8a8b038b9d4db02fb63b
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoImpl.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M packaging/dbscripts/create_views.sql
3 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafb14eb481d099ec89ed8a8b038b9d4db02fb63b
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>