7:45 a.m.
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add network_filter_id column to vnic_profiles
......................................................................
engine: add network_filter_id column to vnic_profiles
The column will be used to configure each vNIC's network filter.
If 'Vdc_Options.EnableMACAntiSpoofingFilterRules' is 'true',
'vdsm-no-mac-spoofing' filter will be set on all the vNic profiles,
otherwise NULL will be set.
In case the vNIC profile points to NULL, no network filter will be
configured for that specific vNIC.
It is important to mention, that libvirt's backward compatibility
version support is assumed, meaning that libvirt will keep supporting
all the filters introduced in older versions. Otherwise the output
for the following scenario is undefined: network N defined in data
center with compatibility version V1 is being assigned to cluster with
compatibility version V2 where V2 > V1, as the network filter of
version V1 may not be supported in hosts of version V2.
The reason for allowing this tightly coupling in libvirt is product
commonality, as other features depending on libvirt assuming backward
compatibility.
Change-Id: I1a7cce4b9b377a4eaf309ad63e87832489b25a16
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkFilterDaoTest.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VnicProfileDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_00_0600_add_network_filter_id_to_vnic_profile.sql
9 files changed, 83 insertions(+), 14 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a7cce4b9b377a4eaf309ad63e87832489b25a16
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>