Change in ovirt-engine[master]: webadmin: NPE while login if there are some running tasks
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: NPE while login if there are some running tasks
......................................................................
webadmin: NPE while login if there are some running tasks
The new SimpleActionTable() in the AlertsEventsFooterView's constructor
triggers the TaskModelProvider.updateDataProvider() which in case there are at
least one started job, triggers the
taskHandler.onRunningTasksCountChange(count). This in turn triggers the call to
AlertsEventsFooterView.setAlertCount() which expects the buttons to be already
inited. But this fields are inited at the end of the constructor which causes
NPE.
Fixed by calling the updateButtonResources() which inits this buttons sooner.
This bug happens in development mode only.
Change-Id: I3315802e33d0bc21ae1810802d1466464e8321b4
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3315802e33d0bc21ae1810802d1466464e8321b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server