Change in ovirt-engine[master]: Revert "restapi: optimize getUriBuilder"
Tal Nisan has submitted this change and it was merged.
Change subject: Revert "restapi: optimize getUriBuilder"
......................................................................
Revert "restapi: optimize getUriBuilder"
This reverts commit d83d67ff715c0707b1715e09249532ca14c7e21a.
The original patch added a static Map that cached UriBuilders. This made
the test "testGet" in "BackendHostNicLabelResourceTest" fail in
some cases.
Since JUnit test order is not deterministic some tests would wrongly use
cached UriBuilders from previous tests and thus fail.
Change-Id: I18db692bcfd0de26bb57481657b7645a01acb7d3
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
2 files changed, 13 insertions(+), 54 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/38165
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18db692bcfd0de26bb57481657b7645a01acb7d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org