Change in ovirt-engine[master]: MoveOrCopyImageGroup - perform unlock when neccessary to avo...
Maor Lipchuk has submitted this change and it was merged.
Change subject: MoveOrCopyImageGroup - perform unlock when neccessary to avoid deadlock
......................................................................
MoveOrCopyImageGroup - perform unlock when neccessary to avoid deadlock
When attempting to revert by executing RemoveImage, there's no need to
unlock the image.
Reasons:
1. It's going to be removed by RemoveImage.
2. The transaction isn't ended when calling RemoveImage, which attempts
to update the same db record, causing to a deadlock.
Change-Id: I3ea9bccb7e1a055613bb9a86d77e784e29f94bc5
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/11328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ea9bccb7e1a055613bb9a86d77e784e29f94bc5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>