Change in ovirt-engine[master]: webadmin, userportal: Enforce dialog close on Escape key
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin,userportal: Enforce dialog close on Escape key
......................................................................
webadmin,userportal: Enforce dialog close on Escape key
When a model-bound dialog is open and the user presses Escape key,
besides executing dialog model's "Cancel" command, dialog close is
enforced by the application.
Note that a dialog model's "Cancel" command should close the dialog
by itself. This patch makes sure that no dialog gets stuck on UI
when the corresponding "Cancel" command fails to close it. This can
happen for many reasons, including exceptions thrown during command
execution.
Change-Id: Ia4b3b6df062a5d32f9ac536cc75a8e143558857b
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java
2 files changed, 51 insertions(+), 7 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4b3b6df062a5d32f9ac536cc75a8e143558857b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>