Change in ovirt-engine[ovirt-engine-3.4]: core: refactor failure to run vm flow - part 4
Oved Ourfali has submitted this change and it was merged.
Change subject: core: refactor failure to run vm flow - part 4
......................................................................
core: refactor failure to run vm flow - part 4
Remove MigrateVmCommand#failedToMigrate which was confusing now that we
have MigrateVmCommand#runningFailed method.
In addition MigrateVmCommand#runningSucceeded is removed.
For the changes above, the calls to CommandBase#freeLock was moved to
the relevant places in RunVmCommandBase, which are better places for
them as they are relevant to all command that extend RunVmCommandBase.
Note that the freeLock method handle the case where the lock is null,
so it is ok in case the command release the lock at the end of the
execute method as well.
Change-Id: I42cefc4c5f7974730a2b38f63f310ab975f73622
Bug-Url: https://bugzilla.redhat.com/1049321
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
3 files changed, 47 insertions(+), 53 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28119
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42cefc4c5f7974730a2b38f63f310ab975f73622
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server