Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: edit running VM is not possible
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: edit running VM is not possible
......................................................................
webadmin: edit running VM is not possible
It was not possible to edit the running VM. The reason was that the
VmNextRunConfigurationModel in constructor always inited the latch which by
default had the 'available' flag set to true (even not shown since this flag
was set sooner than the listener which would actually show it was registered).
As a consequence, the validate() method returned false, since the latch was
"available" and unchecked. But since it was not rendered, it was not obvious to
the user what the problem is making the dialog impossible to submit.
The fix was just to move the initialization of the latch to the proper place.
Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e
Bug-Url: https://bugzilla.redhat.com/1312636
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13f9b6d072c2ba8a2113936e95223df9b9f4db7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>