Change in ovirt-engine[master]: core: Renamed Refresh to refreshModel
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Renamed Refresh to refreshModel
......................................................................
core: Renamed Refresh to refreshModel
Fixes FindBugs issues -
1. VERY confusing to have methods
org.ovirt.engine.ui.uicommonweb.models.events.EventListModel.Refresh() and
org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh()
2. VERY confusing to have methods
org.ovirt.engine.ui.uicommonweb.models.templates.UserPortalTemplateEventListModel.Refresh()
and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh()
3. VERY confusing to have methods
org.ovirt.engine.ui.uicommonweb.models.vms.UserPortalVmEventListModel.Refresh() and
org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh()
Base class of EventListModel already has a function named refresh()
Since here the model is being refreshed ... called it refreshModel()
Change-Id: I6d6b79a13fe9427253cdd2d93cd84c51e1574e0d
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d6b79a13fe9427253cdd2d93cd84c51e1574e0d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>