Change in ovirt-engine[master]: frontend: Correct RunOnce Iso selection
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Correct RunOnce Iso selection
......................................................................
frontend: Correct RunOnce Iso selection
RunOnceDialog ignored persistent configuration of selected CD and
also didn't support unchecking the CD. (Frontend would display as not
attached CD but would run with attached CD anyway)
Now we support that by defaulting the RunVmParams#diskPath to be null
when the user explicitly uncheck the "Attach CD" checkbox.
We also pre-select the value of VmBase#isoPath in the iso listbox.
Change-Id: I714d8fad60673608d58ade4463c4abbcb5eb3f08
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026306
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054743
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
3 files changed, 19 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/25957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I714d8fad60673608d58ade4463c4abbcb5eb3f08
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server