10:41 a.m.
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Fix UI plugin REST API / Engine session refresh issue
......................................................................
webadmin: Fix UI plugin REST API / Engine session refresh issue
Patch http://gerrit.ovirt.org/#/c/35185/ ensured that UI plugin
REST API session uses the existing Engine user session, instead
of creating a separate one.
This caused REST API session heartbeat mechanism to eventually
keep the Engine user session alive, effectively preventing GUI
from auto-logout due to GUI user's inactivity.
This patch syncs REST API session with Engine user session:
upon each backend call that refreshes Engine session (action
or query with refresh=true), REST API session is refreshed.
REST API session refresh is done max. once per 1 minute to
prevent flooding the backend.
Change-Id: I2ffd3198239040f67313238a837af98db16e79ea
Bug-Url: https://bugzilla.redhat.com/1172726
Bug-Url: https://bugzilla.redhat.com/1168842
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/exclude-filters.xml
A
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/EngineSessionRefreshed.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java
M
frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M
frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M
frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManagerTest.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
7 files changed, 90 insertions(+), 11 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ffd3198239040f67313238a837af98db16e79ea
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server