Change in ovirt-engine[master]: webadmin: replace duplicated code with builders
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: replace duplicated code with builders
......................................................................
webadmin: replace duplicated code with builders
Add a builder that maps properties in UnitVmModel to
AddVmTemplateParameters and a builder that is a composite of
KernelParamsVmBaseToVmBaseBuilder
DedicatedVmForVdsVmBaseToVmBaseBuilder
MigrationOptionsVmBaseToVmBaseBuilder
and UsbPolicyVmBaseToVmBaseBuilder.
These builders replace the duplicated code that was added when the
clone template from snapshot operation was added to the snapshots
sub-tab.
Change-Id: Ibfbc42621b15d3115fba2f1da27d8489e72281fc
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/template/UnitToAddVmTemplateParametersBuilder.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/template/VmBaseToVmBaseForTemplateCompositeBaseBuilder.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
4 files changed, 58 insertions(+), 50 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/41639
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfbc42621b15d3115fba2f1da27d8489e72281fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org