Change in ovirt-engine[master]: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirt...

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade ...................................................................... bootstrap: detach OVirtUpgrader from VdsInstaller into OVirtNodeUpgrade Currently we have 4 separate bootstrap methods: 1. Host. 2. Node registration. 3. Node installation. 4. Node upgrade. While there is something common between (1-3), node upgrade is totally different sequence: 1. Unlike bootstrap it is executing foreign code (not originated at engine machine. 2. Unlike bootstrap it is non-customizable. Current implementation shares the same VdsInstaller base class among bootstrap and node upgrade, as these are totally different, we detach the OVirtUpgrader from VdsInstaller. VdsInstaller is soon to be retired. Rename OVirtUpgrader to OVirtNodeUpgrade as it handles only ovirt-node. This change also introduces the SSHDialog class, which is a class that can be used to conduct a text dialog with a component at the other end of the ssh session. It is a key component in the future vdsm-bootstrap rewrite. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875529 Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtUpgrader.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java 8 files changed, 1,249 insertions(+), 110 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff19fdb9f717d424f23bc5d4e5a8df8fce8a58bf Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt; Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com&gt; Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt; Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com&gt; Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;