Change in ovirt-engine[master]: core: improve CDA of AddStorageServerConnection
Allon Mureinik has submitted this change and it was merged.
Change subject: core: improve CDA of AddStorageServerConnection
......................................................................
core: improve CDA of AddStorageServerConnection
Improve canDoAction of AddStorageServerConnectionCommand
to have early returns in failures, and call to its super.canDoAction
since there are checks that are done there and
are not done by the overriding command.
Change-Id: I00a46aac7d642128c287ef633c492f3c1b85f572
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
2 files changed, 15 insertions(+), 11 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00a46aac7d642128c287ef633c492f3c1b85f572
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>