Change in ovirt-engine[master]: core: AddVmPoolWithVmsCommand storage allocation
Arik Hadas has submitted this change and it was merged.
Change subject: core: AddVmPoolWithVmsCommand storage allocation
......................................................................
core: AddVmPoolWithVmsCommand storage allocation
This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for AddVmPoolWithVmsCommand, using only existing
validations.
Previously the storage allocation check was wrongfully in
CommonVmPoolWithVmsCommand, and is now extracted to
AddVmPoolWithVmsCommand only.
Change-Id: I3120acf7eb5c71be6ade437522174a7bf62ea52a
Bug-Url: https://bugzilla.redhat.com/1143888
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java
3 files changed, 73 insertions(+), 28 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3120acf7eb5c71be6ade437522174a7bf62ea52a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server