Change in ovirt-engine[master]: core: Don't send SetStoragePoolDescription

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't send SetStoragePoolDescription ...................................................................... core: Don't send SetStoragePoolDescription The storage pool description is never read in VDSM and thus updating it is a useless (and expensive!) call. Moreover, this call cannot be trusted - since it's only sent if the DC's status is UP, there may very well be a situation where the DC's name in the engine and the pool's description in VDSM do not match. This patch removes this redundant and harmful call. Topic: remove-sp-description Change-Id: I5664c9912d07f9fbb99af315e904270597adbd73 Bug-Url: https://bugzilla.redhat.com/1096215 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetStoragePoolDescriptionVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetStoragePoolDescriptionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 8 files changed, 0 insertions(+), 79 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Federico Simoncelli: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/30464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5664c9912d07f9fbb99af315e904270597adbd73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server