Change in ovirt-engine[master]: core: rename remove storage connection command
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: rename remove storage connection command
......................................................................
core: rename remove storage connection command
Rename removeStorageServerConnection command and VdcAction type
to disconnectStorageServerConnection since this command
disconnects it on vdsm side, but does not remove its record from the db.
It's more correct to call it "disconnect" according to what it actually
does.
It's also preparation for adding (in different patch) a remove command
that actully both disconnects the storage and removes the storage connection from
the db.
Also, remove a big commented piece of code from AddStorageDomainRM
because it's commented out anyway and just makes the class bigger
because of dead code.
Change-Id: I0b6043810a5c4200593befd668a279ea56ff4693
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
R
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
7 files changed, 13 insertions(+), 94 deletions(-)
Approvals:
Alissa Bonas: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11378
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b6043810a5c4200593befd668a279ea56ff4693
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>