Change in ovirt-engine[master]: core: Test GetGlusterGeoReplicationEligibleVolumesQuery#getE...
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Test
GetGlusterGeoReplicationEligibleVolumesQuery#getEligibleVolumes
......................................................................
core: Test GetGlusterGeoReplicationEligibleVolumesQuery#getEligibleVolumes
Enhanced GetGlusterGeoReplicationEligibleVolumesQueryTest so that
getEligibleVolumes is also tested, as it has some non-trivial logic.
This is done in order to facilitate the refactoring of this method.
Change-Id: Ifee0119d1ee0d26cac0543f870e3d7fa44a12672
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
anmolbabu: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifee0119d1ee0d26cac0543f870e3d7fa44a12672
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>