Change in ovirt-engine[master]: engine: Add validation to cpu pinning
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: Add validation to cpu pinning
......................................................................
engine: Add validation to cpu pinning
Validation the following conditions:
- syntax is correct
- all given vcpus exist (e.i vcpu number < max cpu# on vm)
- only one definition for each vcpu
- if defined, a vcpu is pinned to at least one pcpu (e.g 0#1-2,^1,^2 isn't valid)
- in cluster 3.2 verify all pcpu given exists (e.i pcpu number < max thread# on host)
*pcpu is not verified in cluster < 3.2 as we cannot know the nuber for sure.
Change-Id: I690b60fcde6bf337058246ef9b1ee24fa3b7220a
Bug-Url: https://bugzilla.redhat.com/871726
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 251 insertions(+), 37 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I690b60fcde6bf337058246ef9b1ee24fa3b7220a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Andrew Cathrow <andrew(a)cathrow.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>