Change in ovirt-engine[ovirt-engine-3.5]: engine: Do not assign creator as owner to VMs from pool
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Do not assign creator as owner to VMs from pool
......................................................................
engine: Do not assign creator as owner to VMs from pool
If VM is created to attach it to a VM pool, do not assign its creator as
owner in any case. Assignment of a user to the VM in this case will
designate this VM as occupied and prevent other users from taking it.
This assignment happens currently when pool creator doesn't have
MANIPULATE_PERMISSIONS role on the pool VMs.
Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301867
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmAndAttachToPoolParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
4 files changed, 15 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6af18a2b7caa8181523a277f4d63cc688e69a59e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>