Change in ovirt-engine[master]: core: handle hot-set and update running vm
Omer Frenkel has submitted this change and it was merged.
Change subject: core: handle hot-set and update running vm
......................................................................
core: handle hot-set and update running vm
since the numOfSockets field was updateable, the infrastructure of
update-running-vm didn't take it into account,
when this was the only changed field, we had couple of issue:
1. the UI dialog didn't show, user cant choose if to apply now or later
2. next_run snapshot wasn't created
this fix is changine the field to updateableOnStatus, to handle above
issues, but since the user can choose if to use hot plug or not, a new
field introduced to the annotation, to mark fields that can be hot-set.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128443
Change-Id: I1c7f9b26ac4ddda6b446244b1fd85e2023809630
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableOnVmStatusField.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectIdentityCheckerTest.java
6 files changed, 71 insertions(+), 9 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c7f9b26ac4ddda6b446244b1fd85e2023809630
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server