Change in ovirt-engine[master]: userportal: Fix exception on browser resizing
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: Fix exception on browser resizing
......................................................................
userportal: Fix exception on browser resizing
The SideTabExtendedResourceView listens to Window.addResizeHandler
and tries to change it's widget hights.
The problem is, that this recieves the events also when the resources
view is not visible so the widgets' heights are 0 leaving the
calculated new height negative. This throws an assertion exception:
"CSS heights should not be negative".
Fixed by guarding that this size will never be less than zero.
Change-Id: I43238b399a7e4148ebb3c75b3afdac807ad78202
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14240
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43238b399a7e4148ebb3c75b3afdac807ad78202
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>