Change in ovirt-engine[ovirt-engine-3.6]: core: CoCoAsyncTaskHelper - get parent command id from the p...
Tal Nisan has submitted this change and it was merged.
Change subject: core: CoCoAsyncTaskHelper - get parent command id from the parent
parameters
......................................................................
core: CoCoAsyncTaskHelper - get parent command id from the parent parameters
When choosing parent parameters for the tasks the parent command id should be
derived from those parameters, otherwise we can get into situation where
the parentCommandId will be Guid.Empty not matching the selected parent
parameters.
This situation leads to the tasks to be considered as of different commands which
leads to the endAction() method to be called multiple times when the parent command
creates tasks. An example would be the usage of the memory builders, when creating
a vm snapshot with memory the endAction() will be executed multiple times, one time
for the disks tasks and one time for the memory tasks.
Change-Id: I0cacc023e855c8e9651e7134234759288b93e897
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1293663
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/51181
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cacc023e855c8e9651e7134234759288b93e897
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>