Change in ovirt-engine[master]: userportal: createRequestToken should use getHashName (#8507...
Daniel Erez has submitted this change and it was merged.
Change subject: userportal: createRequestToken should use getHashName (#850749)
......................................................................
userportal: createRequestToken should use getHashName (#850749)
https://bugzilla.redhat.com/850749
* AbstractSideTabWithDetailsPresenter -> createRequestToken:
subTabName should be composed of the HashName and not the Title
(i.e. as in the WebAdmin).
Getting the tab's name by its title:
- is wrong due to translation issues (HashName is not translated).
- caused a problem in Templates-Disks sub-tab revealing
after changing 'Virtual Disks' to 'Disks'.
* Renaming HashName from 'virtual_disks' to 'disks' just to
keep on consistency.
Change-Id: I769538944b014ddd69a37ed4c151b607d6266ca1
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmMonitorModel.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/ApplicationPlaces.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractSideTabWithDetailsPresenter.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java
7 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I769538944b014ddd69a37ed4c151b607d6266ca1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>