Change in ovirt-engine[master]: core: CreateAllSnapshotsFromVmCommand#validate
From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CreateAllSnapshotsFromVmCommand#validate
......................................................................
core: CreateAllSnapshotsFromVmCommand#validate
This patch validates that all disks supplied by the user as command
parameters on SDK / REST API are allowed for snapshot, in order to
avoid snapshot's creation for direct-LUN disks.
(And solve the bug below).
The operation will fail with an error message.
Change-Id: Ie2b3d1f9af8dda189d1f438a3bd772e4db9bf9c4
Bug-Url: https://bugzilla.redhat.com/1442037
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 23 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved; Passed CI tests
Shani Leviim: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76997
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b3d1f9af8dda189d1f438a3bd772e4db9bf9c4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>