Change in ovirt-engine[master]: webadmin: reverted removal of selectedItemsChanged method.
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: reverted removal of selectedItemsChanged method.
......................................................................
webadmin: reverted removal of selectedItemsChanged method.
This method was mistakingly removed as a part of one big refactor.
Apparently it was removed because it seems that this method does the
same thing as overriden one, but that's not true, both calls their
private equally named method. This could be fixed by making that
method protected, but after some research this is not easily doable,
so I just returned removed method back and place warning comment to
method being overridden.
Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779
Bug-Url: https://bugzilla.redhat.com/1180897
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server