Change in ovirt-engine[master]: engine: revisit improving VDSM error handling
Roy Golan has submitted this change and it was merged.
Change subject: engine: revisit improving VDSM error handling
......................................................................
engine: revisit improving VDSM error handling
- fix a major issue caused by 1d3c67c9cf7846ab73e6411fb8aebff8a29f9cfb where VdsManager
expects
VdsNetworkException on network issue.
- improved the identifying network error by catching all IOExceptions.
this ease catching corner case protocol error.
- refactor and clean VdsNetworkException and its tree to use a
constructor with a Throwable - cleaned the unuseful "{ClassName}: "
convention which is already implemented in Throwable toString().
Change-Id: I9df04879b15575842da1bd53c39c00a6623374e0
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/ApplicationException.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSExceptionBase.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSGenericException.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSNetworkException.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
5 files changed, 29 insertions(+), 29 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9df04879b15575842da1bd53c39c00a6623374e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>