Change in ovirt-engine[master]: packaging: cleanup _configIptables
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: cleanup _configIptables
......................................................................
packaging: cleanup _configIptables
1. use template file, do not search for comments.
2. remove code duplications.
3. handle files correctly.
4. misc cleanups.
Change-Id: Ic08891752b537ea04c56e8aef2040cc5e89cbea3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/iptables.default
2 files changed, 21 insertions(+), 29 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic08891752b537ea04c56e8aef2040cc5e89cbea3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>