Change in ovirt-engine[ovirt-engine-3.4]: engine: set template id in ctor
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: set template id in ctor
......................................................................
engine: set template id in ctor
When not setting the template id before the execute we have an empty id
for the template.
If we are failing with adding image to the template and the engine is
reset we are deleting the blank template!
When setting the template id right at the beginning prevent this kind of
races.
Bug-Url: https://bugzilla.redhat.com/1105211
Change-Id: I696e572ce87f9fe041a50ca4a88584df385ea353
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I696e572ce87f9fe041a50ca4a88584df385ea353
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server