Change in ovirt-engine[ovirt-engine-3.5]: restapi: Validate QoS type
Piotr Kliczewski has submitted this change and it was merged.
Change subject: restapi: Validate QoS type
......................................................................
restapi: Validate QoS type
Currently when a QoS is added to a data center we don't validate that
the mandatory type is specified. This eventually triggers a NPE when
validating the value. To avoid this this patch adds the validation and
modifies the type validator so that it won't fail if no type is
provided.
Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e
Bug-Url: https://bugzilla.redhat.com/1148773
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit ba3dbd7a4e7e8f516445a9717c9f7a74ddbfe90b)
---
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Gilad Chaplik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/33727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server