Change in ovirt-engine[master]: engine, webadmin: do not invoke HostSetupNetworksCommand wher...
Alona Kaplan has submitted this change and it was merged.
Change subject: engine,webadmin: do not invoke HostSetupNetworksCommand where no changes
were made
......................................................................
engine,webadmin: do not invoke HostSetupNetworksCommand where no changes were made
• discard from HostSetupNetworksCommandParameters all bonds and
network attachments, which are sent to be updated, but they're
equal to already existing Bonds resp. NetworkAttachment in the system.
• added method to HostSetupNetworksCommandParameters to figure out if
there's any change to be done in them, and this method is used both on UI and
bll to figure out, whether changes needs to be done to the system.
Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c
Bug-Url: https://bugzilla.redhat.com/1254320
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
4 files changed, 145 insertions(+), 35 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc4c17171ed37cea79ea80aa65b7f2a056ca407c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>