Change in ovirt-engine[master]: core: replaced 'unless' with 'when'
Alona Kaplan has submitted this change and it was merged.
Change subject: core: replaced 'unless' with 'when'
......................................................................
core: replaced 'unless' with 'when'
'unless' with lot of negations is almost not readable(don't do
something when something is not true). Simple 'when' is much clearer(do it when).
• replaced 'unless' with 'when'
• negated boolean expression passed to this function to preserve same meaning
Change-Id: I027709a58c35836a461362eb4e94313ffd66e79a
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
1 file changed, 19 insertions(+), 10 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/36569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I027709a58c35836a461362eb4e94313ffd66e79a
Gerrit-PatchSet: 58
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org