Change in ovirt-engine[master]: webadmin: Get "UnassignedDataCenterId" using class instead o...
Juan Hernandez has submitted this change and it was merged.
Change subject: webadmin: Get "UnassignedDataCenterId" using class instead of
instance
......................................................................
webadmin: Get "UnassignedDataCenterId" using class instead of instance
This is needed in order to avoid the following find bugs warning:
Return value of method without side effect is ignored
This code calls a method and ignores the return value. However our
analysis shows that the method (including its implementations in
subclasses if any) does not produce any effect other than return value.
Thus this call can be removed.
We are trying to reduce the false positives as much as possible, but in
some cases this warning might be wrong. Common false-positive cases
include:
- The method is designed to be overridden and produce a side effect in
other projects which are out of the scope of the analysis.
- The method is called to trigger the class loading which may have a
side effect.
- The method is called just to get some exception.
If you feel that our assumption is incorrect, you can use a
@CheckReturnValue annotation to instruct FindBugs that ignoring the
return value of this method is acceptable.
Bug kind and pattern: RV - RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT
Change-Id: I897dab051d8200b22ff2b8a39a6c9a2d3075ef1e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Alexander Wels: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I897dab051d8200b22ff2b8a39a6c9a2d3075ef1e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org