Change in ovirt-engine-cli[master]: cli: --storagedomain appears as an option in all vm actions ...
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: --storagedomain appears as an option in all vm actions #856164
......................................................................
cli: --storagedomain appears as an option in all vm actions #856164
The reason for this is that actions for vm exist in two dimensions,
1. None
2. storagedomain
e.g vm has actions when it in context of storagedomain (like import)
and without any context (like start, stop, etc.), auto-completion refactored
to be action context-aware and exclude not relevant options for the
given context.
https://bugzilla.redhat.com/show_bug.cgi?id=856164
Change-Id: Ie8daaf69385450ab8e17d041e2309ad3a0e29a33
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/shell/actioncmdshell.py
M src/ovirtcli/shell/cmdshell.py
M src/ovirtcli/utils/autocompletionhelper.py
3 files changed, 130 insertions(+), 32 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8daaf69385450ab8e17d041e2309ad3a0e29a33
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>