Change in ovirt-engine[master]: userportal: clone VM create VM with wrong permissions(#80977...
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: clone VM create VM with wrong permissions(#809778)
......................................................................
userportal: clone VM create VM with wrong permissions(#809778)
https://bugzilla.redhat.com/809778
Extended->Virtual Machines->select one->Snapshots->select one->clone
It created a new VM but invisible for the user which created it.
The problem was in VmSnapshotListModel.OnCloneVM() which
did not mark the creator to be the explicit owner
(AddVmFromSnapshotParameters.setMakeCreatorExplicitOwner())
Solved by creating a snapshot model specially for user portal
(UserPortalVmSnapshotListModel) which sets this flag to true.
Change-Id: I25aa6e78a4c6d7d516a97a910e5d57e4a0447341
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTree.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
A
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmSnapshotListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/vm/SubTabExtendedVmSnapshotPresenter.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/vm/SubTabExtendedVmSnapshotView.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmSnapshotListModelProvider.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineSnapshotView.java
8 files changed, 41 insertions(+), 19 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25aa6e78a4c6d7d516a97a910e5d57e4a0447341
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>