Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Template's empty string as a disk alias UI fix.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Template's empty string as a disk alias UI fix.
......................................................................
webadmin: Template's empty string as a disk alias UI fix.
While making a new template based on a VM, providing the template's
allocated disks's alias as an empty string is now disabled ALSO BY UI.
the user should not be able to create a template with disks that have
an empty aliases- this bug has already been fixed at the BACKEND, this
current patch prevents the user from giving an empty alias at UI level.
Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Bug-Url: https://bugzilla.redhat.com/1110304
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit http://gerrit.ovirt.org/34606
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I246063773e423f1e34ace3acd3f3884b282597e7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server