Change in ovirt-engine[master]: webadmin, userportal: Fix client-side sort issue
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix client-side sort issue
......................................................................
webadmin,userportal: Fix client-side sort issue
This patch fixes an issue where items would disappear
from grid when activating client-side column sorting.
This patch does not attempt to guarantee stability of
sorting behavior in relation to fresh items retrieved
from server. In other words, following edge case:
a, apply client-side sorting on column A
b, apply client-side sorting on column B
c, refresh items, some items might switch positions
In future, we can improve sorting logic to guarantee
stability of sorting vs. refresh behavior.
Change-Id: I437e9dd7ff2afdb2d87fb0ba6c17dcb081cd965d
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModel.java
A
frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/SortedListModelTest.java
2 files changed, 153 insertions(+), 8 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified; Looks good to me, approved
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I437e9dd7ff2afdb2d87fb0ba6c17dcb081cd965d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server