7:30 p.m.
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fix Coverity issues related to tooltips
......................................................................
userportal, webadmin: fix Coverity issues related to tooltips
* 1291168 Dereference null return value
If the function actually returns a null value, a NullPointerException
will be thrown.
In org.ovirt.engine.ui.userportal.widget.QuotaProgressBar.setValues
* 1289478 Missing call to superclass
Whatever action the superclass method implements will not occur, if
the superclass call is actually required.
In org.ovirt.engine.ui.webadmin.widget.table.cell.MenuCell.onBrowserEvent
* 1289477 Logically dead code
The indicated dead code may have performed some action; that action will
never occur.
In org.ovirt.engine.ui.common.widget.table.cell.RadioboxCell.onBrowserEvent
* 1289467, 1289468, 1289469, 1289470 Missing break in switch
Execution falls through to the next case statement or default; this might
indicate a common typo.
In
org.ovirt.engine.ui.webadmin.widget.table.column.VolumeStatusColumn.getTooltip
* 1289466 Dereference null return value
If the function actually returns a null value, a NullPointerException will
be thrown.
In org.ovirt.engine.ui.common.widget.uicommon.popup.vm.
VmSnapshotCustomPreviewPopupWidget$10.getTooltip
* 1289462, 1289463, 1289464, 1289465 Unused value
An assigned value that is never used may represent unnecessary computation,
an incorrect algorithm, or possibly the need for cleanup or refactoring.
In
org.ovirt.engine.ui.webadmin.widget.table.column.VolumeStatusColumn.getTooltip
* 1289461 Useless call
A function call that seems to have an intended effect has no actual effect
on the logic of the program.
In
org.ovirt.engine.ui.userportal.widget.table.column.AbstractMaskedVmImageColumn.
render
* 1289460 SF: Switch case falls through
In
org.ovirt.engine.ui.webadmin.widget.table.column.VolumeStatusColumn.getTooltip
* 1289459 SIC: Inner class could be made static
This class is an inner class, but does not use its embedded reference to the
object which created it.
Change-Id: Iec6a015fb0083cec224290b31b7e981cc9841ffb
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/RadioboxCell.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/AbstractMaskedVmImageColumn.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/MenuCell.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java
7 files changed, 17 insertions(+), 10 deletions(-)
Approvals:
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec6a015fb0083cec224290b31b7e981cc9841ffb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server