Change in ovirt-engine[master]: core: Config mocking in StoragePoolValidatorTest
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Config mocking in StoragePoolValidatorTest
......................................................................
core: Config mocking in StoragePoolValidatorTest
Used the standard was of mocking Config - MockConfigRule.
This refactoring enables removing the useless getConfigValue method
from the StoragePoolValidator class, and just call Config.GetValue
directly instead.
Change-Id: I03c0f2a1c013cd12010be7f84d896c1d1e600c29
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java
2 files changed, 13 insertions(+), 15 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03c0f2a1c013cd12010be7f84d896c1d1e600c29
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>