Change in ovirt-engine[master]: engine: Check for conflicting address when hotplugging a disk
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Check for conflicting address when hotplugging a disk
......................................................................
engine: Check for conflicting address when hotplugging a disk
When a disk image is hotplugged and it has a stored address we have to
check if that address is not taken by another plugged disk and if that's
the case we should remove the address from the disk that's going to be
hotplugged.
The rationale behind this is: when a disk is hotunplugged qemu may free the
disk's address for further use. If another disk is hotplugged that
address may be given to the new device. Thus would cause that when the
first disk is hotplugged again its address will be rejected because
it's in use by the second disk.
Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2
Bug-Url: https://bugzilla.redhat.com/1079697
Signed-off-by: Xavi Francisco <xfrancis(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M packaging/dbscripts/vm_device_sp.sql
5 files changed, 49 insertions(+), 1 deletion(-)
Approvals:
Xavi Francisco: Verified
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Looks good to me, approved
Liron Ar: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server